Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of 'not callable using argument types' error message II #16096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryuukk
Copy link
Contributor

@ryuukk ryuukk commented Jan 25, 2024

This is continuation of #16045

I think it could be further improved btw, but i don't like how getParamError is its own thing, i can't put a 2 line and change colors to display something like:

myfunction(string aa, int bb)   <-- in red
                      ^^^^^^    <-- cursor

This would be 100x more readable, and remove the need of the suplemental error messages

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ryuukk! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16096"

@ryuukk
Copy link
Contributor Author

ryuukk commented Jan 25, 2024

I have used make test AUTO_UPDATE=1 and looks like it incorrectly put my own paths.. how to fix that?

What is the proper way to automate updating the tests?

(spec:1) compilable/test23097.d(15): Error: generated function `opAssign` is not callable using argument types `(const(S23097))`
(spec:2) compilable/test23097.d(15): Error: `inout` constructor `test23097.S23097.this` creates const object, not mutable
(spec:1) compilable/test23097.d(15): `struct S23097` does not define a copy constructor for `const(S23097)` to `S23097` copies
(spec:1) compilable/test23097.d(26): `test23097.S23097.opAssign(S23097 p)` declared here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble understanding why opAssign is relevant for this error message.

@RazvanN7
Copy link
Contributor

I have used make test AUTO_UPDATE=1 and looks like it incorrectly put my own paths.. how to fix that? What is the proper way to automate updating the tests?

That is the correct way, however, this PR suffers from the same problem described here: #16045 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants