Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update notebook #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update notebook #9

wants to merge 1 commit into from

Conversation

tomvannuenen
Copy link
Contributor

Updated this notebook as it was very long in the tooth and way too complex at the end with a challenge that caused significant attendance drop.

Notebook still needs a final challenge but this update already solves some of these pedagogical issues.

@pssachdeva
Copy link
Member

  • I think the "To Scrape or Not To Scrape" section can be removed. It should be covered in the slides (are we still doing those?)
  • Typo in Step 2: Parse the Page..: "Now, we use the BeautifulSoup... to parse the response..."
  • Do you think there should be accompanying images with the "find" sections so that students know what HTML corresponds to what in the webpage?
  • Perhaps "Inspect Element" should be explicitly introduced. I usually do this anyway but it could be a good cue for future instructors

Overall, I think this looks good, and you can merge. It may still be too long to fit in 2 hours but it's worth another run to see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants