Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doors get a clipbox size so units do not get stuck inside #3235

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Doors get a clipbox size so units do not get stuck inside #3235

wants to merge 4 commits into from

Conversation

Loobinex
Copy link
Member

@Loobinex Loobinex commented May 10, 2024 •
edited

also fixes an issue with gas damage not hitting units doing combat with doors
#3236

@Loobinex Loobinex marked this pull request as draft May 11, 2024 21:58
@Loobinex Loobinex marked this pull request as ready for review May 11, 2024 21:58
@Loobinex
Copy link
Member Author

AncientWay tested this PR and confirmed it fixes #3236

He also noticed 2 other differences:

  1. Units behind a locked door will no longer start screaming when the door is attacked. If creatures they will keep working.
  2. Units escaping lava through a door will now get stuck finding a space to attack. Before this PR only ranged units had this issue. See image.

image

@Loobinex Loobinex requested a review from PieterVdc May 14, 2024 22:00
@Loobinex Loobinex marked this pull request as draft May 15, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PieterVdc PieterVdc Awaiting requested review from PieterVdc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Loobinex @PieterVdc