Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Spell Effect: Rage with its Keeper Power #2982

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

walt253
Copy link
Contributor

@walt253 walt253 commented Jan 27, 2024

Introduces a new Spell Effect: Rage.

“Makes the creature attack recklessly, hitting harder and faster without dodging.”

Multiply strength of user by 1.5, its speed by 2, halves cooldown of abilities by 2, set its defense stat to 0.
The speed bonus and cooldown reduction STACK with speed, this is intended!
This means a creature under Speed and Rage can deal a lot more damage than usual.

Bundled with a Keeper Power that apply Rage effect on the target.

@walt253 walt253 marked this pull request as ready for review January 27, 2024 13:33
@walt253
Copy link
Contributor Author

walt253 commented Jan 27, 2024

I also made minors changes regarding comments on creature.cfg and magic.cfg.

config/fxdata/magic.cfg Outdated Show resolved Hide resolved
"damage is in points per game turns" -> "damage is in points per turn"
@walt253 walt253 marked this pull request as draft January 28, 2024 16:50
Implements new mechanic HealthCost for Keeper Power, set a value in percentage that will substract from current health of target.
@walt253 walt253 marked this pull request as ready for review February 5, 2024 16:32
@walt253 walt253 marked this pull request as draft April 9, 2024 07:06
@walt253 walt253 marked this pull request as ready for review April 9, 2024 07:06
@walt253 walt253 marked this pull request as draft April 14, 2024 08:07
@walt253 walt253 marked this pull request as ready for review April 14, 2024 08:08
@walt253
Copy link
Contributor Author

walt253 commented May 18, 2024

mh those conflicts are not easy 🤔

you may want to cherry pick stuff from this commit: a7a4792861a9e747d10dbad9c35aa24efa971ea3

I'm thinking to close this PR, since #3212 is a good step towards more configurable keeper power and ultimately instead of hardcoding more stuff might be best to do something different for this rage buff. 🤔

Up to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants