Flag for all spell immunities #2934
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walt253
reviewed
Jan 5, 2024
| @@ -47,7 +47,6 @@ enum CreatureModelFlags { | |||
| CMF_IsLordOTLand = 0x0008, // simply, Knight | |||
| CMF_IsSpectator = 0x0010, // simply, Floating spirit | |||
| CMF_IsEvil = 0x0020, // All evil creatures | |||
| CMF_NeverChickens = 0x0040, // Cannot be affected by Chicken (for Avatar) | |||
There was a problem hiding this comment.
shouldn't this one replaced with a dummied out property instead?
disease is ok to be removed cause is at end of list but for that one there is a hole now or I'm misunderstanding it 🤔
There was a problem hiding this comment.
yes, will add some comments there sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creatures can be immune to any spell effect, not just gas, chicken and disease.