Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadruple THINGS_COUNT #2824

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

Conversation

walt253
Copy link
Contributor

@walt253 walt253 commented Dec 10, 2023

From 8192 to 32767.

I assume it's a short?

Why this PR?

Support for big maps 170x170 that are 4 times larger than a standard sized map.

@walt253
Copy link
Contributor Author

walt253 commented Dec 18, 2023

It works:

image

test_map.zip

But I noticed that the game slowdown once I reach 16k+ things, but maybe it's the test map script at cause?

It spawns 240 Demonspawn per second then kill them instantly and each of them spawn 4 bag of gold.

@walt253 walt253 marked this pull request as ready for review December 18, 2023 21:00
@walt253 walt253 marked this pull request as draft December 26, 2023 03:29
@walt253 walt253 marked this pull request as ready for review December 28, 2023 16:38
@Samsoee
Copy link

Samsoee commented Dec 28, 2023

Tested these 32k objects with Walter on my gaming PC with an I9 13900KF.
low-framerate
higher-framerate

Whenever a new round of bags spawn it lowers the rate to 5fps, but with 32k objects without new spawning it seems stable at 17fps which is playable.

@Loobinex
Copy link
Member

17 FPS with a high end gaming PC does not seem like such a great idea to me.

@Samsoee
Copy link

Samsoee commented Dec 29, 2023

17 FPS with a high end gaming PC does not seem like such a great idea to me.

Well i just tested, just loading a map where i got nothing but imps and a dungeon heart. it is about 160 fps.
But isnt the game limited to 24 fps anyways?

@Loobinex
Copy link
Member

17 FPS with a high end gaming PC does not seem like such a great idea to me.

Well i just tested, just loading a map where i got nothing but imps and a dungeon heart. it is about 160 fps. But isnt the game limited to 24 fps anyways?

The game was limited to 20 fps (the same as the 20 ticks or turns per second) but now the framerate unlocked.

@walt253 walt253 marked this pull request as draft December 30, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants