Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MACinNumberField to MA flavor #507

Merged
merged 3 commits into from
May 22, 2024

Conversation

AbdelYsf
Copy link
Contributor

@AbdelYsf AbdelYsf commented May 15, 2024

Adding CIN field to morocco's falvor, The CIN represents the ID of a Moroccan citizen
It is an 8-max-length string that starts with one or two Latin letters followed by digits,
with the first digit not being zero.
Implemented as in the official government site "https://www.cnie.ma/"

@AbdelYsf AbdelYsf marked this pull request as ready for review May 15, 2024 18:51
benkonrath
benkonrath previously approved these changes May 16, 2024
Copy link
Member

@benkonrath benkonrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good. Just the two small points address. Let me know if you have any questions or remarks.

localflavor/ma/forms.py Outdated Show resolved Hide resolved
localflavor/ma/forms.py Outdated Show resolved Hide resolved
@benkonrath benkonrath dismissed their stale review May 16, 2024 12:45

I meant to "request changes"

@AbdelYsf AbdelYsf requested a review from benkonrath May 16, 2024 23:38
Copy link
Member

@benkonrath benkonrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@benkonrath benkonrath merged commit bd07715 into django:master May 22, 2024
7 checks passed
@AbdelYsf AbdelYsf deleted the ADD-MA-CIN-NUMBER-FIELD branch May 22, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants