Allow fields to be omitted from list/detail form of resources #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 19, 2012 15:13
Conflicts: tastypie/fields.py Pass use_in to the superclass. Conflicts: tastypie/fields.py Tests for related resources
|
I realized that this wasn't working for related fields. Fixed that in the last commit. |
| @@ -65,6 +71,7 @@ def __init__(self, attribute=None, default=NOT_PROVIDED, null=False, blank=False | |||
| self.readonly = readonly | |||
| self.value = None | |||
| self.unique = unique | |||
| self.use_in = use_in if use_in in ['all', 'detail', 'list'] or callable(use_in) else 'all' | |||
There was a problem hiding this comment.
I'd like this line to be broken down more. It's difficult to read as it stands. Perhaps start with the default, then with multiple if statements to apply the options.
|
Other than that piece of feedback, |
|
Fixed in SHA: fc4140c |
|
@numan, I was playing and trying out the
|
|
was fixed in pull request #841 |
|
yup. The fix should be in a new release coming out soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request based on the patch by @funkybob in #526. Most of the credit should go to him. Also addresses #18. Things I added to the patch:
use_incan be a callback that is passed a bundle.use_indefaults toallif it is not a callable,list, ordetail