Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django 2.1 compat #1562

Merged
merged 8 commits into from Aug 28, 2018
Merged

Django 2.1 compat #1562

merged 8 commits into from Aug 28, 2018

Conversation

georgedorn
Copy link
Contributor

Roll up of changes needed to support 2.1. Open PRs related to Django 2.1 compatibility against this branch.

@georgedorn georgedorn added the django-update Changes for new releases of Django label Aug 6, 2018
@georgedorn georgedorn added this to the v0.14.2 milestone Aug 6, 2018
@georgedorn
Copy link
Contributor Author

Known issue: #1561

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.059% when pulling 53aed4b on django-2.1 into 6721e37 on master.

@coveralls
Copy link

coveralls commented Aug 6, 2018 •
edited

Coverage Status

Coverage decreased (-0.1%) to 94.922% when pulling 39e3e49 on django-2.1 into 6721e37 on master.

georgedorn and others added 2 commits August 13, 2018 07:40
@georgedorn
Django 2.1: fix missing QUERY_TERMS (#1564)
8bf1c5e 
* Isolate failing assertion in separate test

* query_terms: try interrogating the django field directly

* Replace class_lookups with get_lookups() which is a more complete list
@georgedorn
Leftover debug
d9a732c
@georgedorn georgedorn mentioned this pull request Aug 13, 2018
Closed
@georgedorn
Copy link
Contributor Author

This test is failing:
FAIL: test_multiple (core.tests.paginator.PaginatorTestCase)

This is due to a regression in django 2.1. There's a fix here but it hasn't been released yet:
django/django@d8e2be4

Note that it says "due to lazily-written tests" and I generally agree; QueryDict when populated from an actual HTTP request will always be strings, not ints, and our tests should be written to reflect that.

@georgedorn
Copy link
Contributor Author

georgedorn commented Aug 13, 2018 •
edited

Status update:
The only remaining test failures are in the core tests:

./manage_core.py test core.tests --traceback -t core
FAIL: test_build_schema (core.tests.resources.ModelResourceTestCase)
FAIL: test_fields (core.tests.resources.ModelResourceTestCase)
FAIL: test_get_schema (core.tests.resources.ModelResourceTestCase)
FAIL: test_get_schema_with_related (core.tests.resources.ModelResourceTestCase)
FAIL: test_get_schema_with_related_resource_not_in_urls (core.tests.resources.ModelResourceTestCase)
FAILED (failures=5, skipped=2)

Several of these seem related, so there may only be a handful of things left to fix.

georgedorn and others added 4 commits August 20, 2018 07:21
@georgedorn
Django 2.1: explicitly set blank=True on BooleanFields due to upstrea…
9dd62f4 
…m regression (#1567)

Failing tests unrelated to this PR; those will need another compat shim (and pep8).
@georgedorn
Fix/django2.1 cleanups (#1568)
056c742 
* Fix pep8

* Remove tests for Django 1.8

* More 1.8 removal, stop installing django 2 on python 2

* More dependency fixes
@georgedorn
Explicitly run doctests for validate_jsonp module, to bump coverage
92fd7b7
@georgedorn
flake8
39e3e49
@georgedorn georgedorn merged commit c9f4ce6 into master Aug 28, 2018
@georgedorn
Copy link
Contributor Author

Going to test master on a handful of sites I run, on Django 2.0. Anybody trying to upgrade to Django 2.1, feel free to test in the next week, and I'll release to PyPI on 9/3 if no major bugs are found.

saedmansour pushed a commit to segmanta/django-tastypie that referenced this pull request Dec 19, 2019
@georgedorn @saedmansour
Django 2.1 compat (django-tastypie#1562)
f474a1f 
* Django 2.1: Set up test matrix

* Django 2.1: fix missing QUERY_TERMS (django-tastypie#1564)

* Isolate failing assertion in separate test

* query_terms: try interrogating the django field directly

* Replace class_lookups with get_lookups() which is a more complete list

* Leftover debug

* Django 2.1: 'Fix' for upstream regression regarding non-string query params in tests (django-tastypie#1565)

* Django 2.1: explicitly set blank=True on BooleanFields due to upstream regression (django-tastypie#1567)

Failing tests unrelated to this PR; those will need another compat shim (and pep8).

* Fix/django2.1 cleanups (django-tastypie#1568)

* Fix pep8

* Remove tests for Django 1.8

* More 1.8 removal, stop installing django 2 on python 2

* More dependency fixes

* Explicitly run doctests for validate_jsonp module, to bump coverage

* flake8
pavanv pushed a commit to pavanv/django-tastypie that referenced this pull request Mar 3, 2021
@georgedorn @pavanv
Django 2.1 compat (django-tastypie#1562)
e9e1d01 
* Django 2.1: Set up test matrix

* Django 2.1: fix missing QUERY_TERMS (django-tastypie#1564)

* Isolate failing assertion in separate test

* query_terms: try interrogating the django field directly

* Replace class_lookups with get_lookups() which is a more complete list

* Leftover debug

* Django 2.1: 'Fix' for upstream regression regarding non-string query params in tests (django-tastypie#1565)

* Django 2.1: explicitly set blank=True on BooleanFields due to upstream regression (django-tastypie#1567)

Failing tests unrelated to this PR; those will need another compat shim (and pep8).

* Fix/django2.1 cleanups (django-tastypie#1568)

* Fix pep8

* Remove tests for Django 1.8

* More 1.8 removal, stop installing django 2 on python 2

* More dependency fixes

* Explicitly run doctests for validate_jsonp module, to bump coverage

* flake8
@georgedorn georgedorn deleted the django-2.1 branch January 24, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
django-update Changes for new releases of Django
Projects
None yet
Milestone
v0.14.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georgedorn @coveralls