New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit error when ModelResource lacks object_class and queryset #1518

Merged

georgedorn merged 3 commits into master from fix/modelresource_no_object_class

Jul 10, 2017

Contributor

georgedorn commented Jul 10, 2017

Addresses recurring not-a-bugs:
#1475, #1517

Note that there's no exception for abstract ModelResource base classes; tastypie doesn't really implement those yet. I plan to address that in a future PR; for now, they should just set Meta.queryset = None and/or Meta.object_list = None for now.

georgedorn added 3 commits

July 10, 2017 07:33


          Add explicit error when ModelResource lacks object_class and queryset

6b3d997


          flake8

04a910d


          Python 3 exception message

2a3dcaf

coveralls commented Jul 10, 2017

Coverage decreased (-0.1%) to 94.834% when pulling 6b3d997 on fix/modelresource_no_object_class into c2bbd60 on master.

4 similar comments

coveralls commented Jul 10, 2017

Coverage decreased (-0.1%) to 94.834% when pulling 6b3d997 on fix/modelresource_no_object_class into c2bbd60 on master.

coveralls commented Jul 10, 2017

Coverage decreased (-0.1%) to 94.834% when pulling 6b3d997 on fix/modelresource_no_object_class into c2bbd60 on master.

coveralls commented Jul 10, 2017

Coverage decreased (-0.1%) to 94.834% when pulling 6b3d997 on fix/modelresource_no_object_class into c2bbd60 on master.

coveralls commented Jul 10, 2017

Coverage decreased (-0.1%) to 94.834% when pulling 6b3d997 on fix/modelresource_no_object_class into c2bbd60 on master.

coveralls commented Jul 10, 2017 •

edited

Coverage increased (+0.004%) to 94.946% when pulling 2a3dcaf on fix/modelresource_no_object_class into c2bbd60 on master.

georgedorn merged commit 7dedb7b into master

georgedorn deleted the fix/modelresource_no_object_class branch

July 10, 2017 15:46

saedmansour pushed a commit to segmanta/django-tastypie that referenced this pull request


          Add explicit error when ModelResource lacks object_class and queryset (…

9e3f8cc

…django-tastypie#1518)

* Add explicit error when ModelResource lacks object_class and queryset

pavanv pushed a commit to pavanv/django-tastypie that referenced this pull request


          Add explicit error when ModelResource lacks object_class and queryset (…

9bdc6ee

…django-tastypie#1518)

* Add explicit error when ModelResource lacks object_class and queryset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment