Fallback to first site_id when current site_id is not in PARLER_SETTINGS #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichoski
force-pushed
the
support-for-dynamic-site-ids
branch
from
7411ead
to
8f672c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects have multi-site setup where sites can be added dynamically at run time, and the new sites end up with their SITE_ID not present in PARLER_LANGUAGES. This makes the language tabs in the admin pages not show for thew newly added sites.
This fix adds a fallback in these situations, where if the current SITE_ID is not present in PARLER_LANGUAGES, the first defined site_id in PARLER_LANGUAGES will be used.