Permit Field Name Conflicts To Ease Existing Field Migrations #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is causing an n+2
Query database for translated content if translation was cached as missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to enable easier migration of existing fields by disabling the proxy fields using a new setting,
PARLER_PERMIT_FIELD_NAME_CONFLICTS.Further Information
The documentation for making existing fields translatable does not work when executing the
makemigrationcommand, as an error is thrown with the messageThe model '{shared_model.__name__}' already has a field named '{name}'.The proposal is to skip this error and not contribute the proxy class only when the
PARLER_PERMIT_FIELD_NAME_CONFLICTSsetting isTrue. This means the "old field" can exist, while thedjango-parlerschema can be created. Translations fromdjango-parlermust be sourced from thetranslationsrelationship.This enables a developer to perform a 3-step zero downtime migration, or slowly roll in
django-parler.Issues
Closes #263
Closes #254