Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Address issues of PR 216 #219

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

shun-liang
Copy link

@shun-liang shun-liang commented Mar 11, 2018

This PR is based on #216, and is to address the comments raised in that PR.

The diff between this PR and #216 can be seen at Andrey-Skvortsov#1

Done:

TODO:

@shun-liang shun-liang changed the title Address issues of PR 216 [WIP] Address issues of PR 216 Mar 11, 2018
@codecov
Copy link

codecov bot commented Mar 12, 2018

Codecov Report

Merging #219 into master will increase coverage by 1.02%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   86.19%   87.22%   +1.02%     
==========================================
  Files          30       31       +1     
  Lines        1797     1933     +136     
==========================================
+ Hits         1549     1686     +137     
+ Misses        248      247       -1
Impacted Files Coverage Δ
example/article/tests.py 98.8% <ø> (ø) ⬆️
parler/tests/test_model_construction.py 93.42% <100%> (+1.01%) ⬆️
parler/tests/test_querysets.py 100% <100%> (ø)
parler/tests/test_model_inheritance.py 100% <100%> (ø) ⬆️
parler/tests/test_query_count.py 96.49% <89.47%> (-3.51%) ⬇️
parler/tests/testapp/models.py 94.32% <95.23%> (+0.15%) ⬆️
parler/utils/fields.py 96.29% <96.29%> (ø)
parler/managers.py 91.21% <98.52%> (+6.21%) ⬆️
parler/cache.py 65.62% <0%> (-3.13%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875f64a...c06382f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants