New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Address issues of PR 216 #219
Open
shun-liang
wants to merge
12
commits into
django-parler:master
Choose a base branch
from
yoyowallet:reduce-number-of-db-queries
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Address issues of PR 216 #219
shun-liang
wants to merge
12
commits into
django-parler:master
from
yoyowallet:reduce-number-of-db-queries
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add django-composite-foreignkey to deps
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 86.19% 87.22% +1.02%
==========================================
Files 30 31 +1
Lines 1797 1933 +136
==========================================
+ Hits 1549 1686 +137
+ Misses 248 247 -1
Continue to review full report at Codecov.
|
…elect_related_translations
vdboor
force-pushed
the
master
branch
4 times, most recently
from
November 18, 2021 09:26
2bf75d2
to
577ca2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #216, and is to address the comments raised in that PR.
The diff between this PR and #216 can be seen at Andrey-Skvortsov#1
Done:
get_extra_related_translation_paths
SelectRelatedTranslationsQuerySetMixin
TODO: