Update shortcuts.py #769
Open
Update shortcuts.py #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactoring code with set comprehension which is more concise and efficient
|
Could you remove redundant line |
|
Okay, I remove the |
sevdog
reviewed
May 8, 2023
Comment on lines
555
to
556
| for code in global_perms: | ||
| codenames.remove(code) |
There was a problem hiding this comment.
It could also be pointed that this operation may be rewritted using set operators:
codenames = codenames - global_perms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored code with set comprehension which is more concise and efficient，how do think this change which has practical value？
refactoring code with set comprehension which is more concise and efficient