union users and groups for better perf #768
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our benchmarks, the current
get_users_with_perms
shortcut is improved by unioning when using thewith_group_users
flag. For our typical usecases, this drops query time by ca. 60% (5ms -> 2ms) with reasonably large production tables running on postgres, and cut the number of queries in half (as we do not force execution of the group id query, which I suspect was done for performance reasons anyway).Of course, I am sure that other database query planners may perform differently, but it is likely that the union approach still comes out ahead sufficiently by avoiding an outer join on potentially large tables.