Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect GUARDIAN_GET_CONTENT_TYPE during ctype match check in guardian.shortcuts.get_objects_for_user #728

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Respect GUARDIAN_GET_CONTENT_TYPE during ctype match check in guardian.shortcuts.get_objects_for_user #728

wants to merge 3 commits into from

Conversation

markedwards
Copy link

@ad-m
Copy link
Member

ad-m commented Dec 27, 2020

Could you add tests to avoid regression?

@markedwards
Copy link
Author

I realised there is the same issue in get_objects_for_group, so I made the same change there. Also, added tests to confirm that calls to get_objects_for_user and get_objects_for_group do not raise when GET_CONTENT_TYPE is overridden.

@danielshorten danielshorten mentioned this pull request Oct 31, 2022
Open
@kmmbvnr kmmbvnr mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad-m ad-m ad-m approved these changes

@Rainshaw Rainshaw Rainshaw approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check in get_objects_for_user does not respect GUARDIAN_GET_CONTENT_TYPE
3 participants
@markedwards @ad-m @Rainshaw