Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.8 #656

Merged
merged 1 commit into from Nov 14, 2019
Merged

Conversation

michael-k
Copy link
Collaborator

No description provided.

@ad-m ad-m merged commit 7308d61 into django-guardian:devel Nov 14, 2019
@michael-k michael-k deleted the python3.8 branch November 14, 2019 13:20
@ad-m
Copy link
Member

ad-m commented Nov 16, 2019

@michael-k , I noticed that you have a long history of cooperation with this project. All your changes to the project are just done correctly. Will you allow me to give you direct write access to the repository? In this regard, I have obtained the approval of all other persons with such permissions.

I am writing here because this is your last contribution to the project and you have not published any contact details in your GitHub profile.

@michael-k
Copy link
Collaborator Author

Will you allow me to give you direct write access to the repository?

Yeah, sure. :)

I saw #603 and thought about the “commit bit” for some time, but my contributions were mostly pull requests. Since I value code reviews, the difference between having write access or not might not be significant.

@ad-m
Copy link
Member

ad-m commented Nov 23, 2019

@michael-k Permissions granted. You now have the permissions, among others to accept others' changes, even if you don't want to be a judge in your own case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants