Fallback to Model Permissions (Core) #546
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #380, and #49.
This updates core.py and test_core.py to allow the following checker functions optionally fallback to (or include) model level permissions:
Please note the fallback_to_model parameter.
This also includes, a global setting two that end:
FALLBACK_TO_MODEL
. Function level takes precedence if both provided. Overall defaults to False in order not to change the default behavior.When get_perms is used with
fallback_to_model=True
, the combined permissions go through the existing caching mechanism, so a performance degradation is not expected (although not tested).Tests are implemented, but documentation is not. More is planned.