Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to concatenate files before processing #286

Conversation

jannon
Copy link

@jannon jannon commented Jul 16, 2012

Setting the option group_first=true in the compress template tag (requires #285) will cause files of the same type to be concatenated before being handed to precompilers/filters. This will allow people to do standard code decomposition with things like .less files (having a mixins file separate from page-specific files)

For example:

{% compress css group_first=true %}
    <link rel="stylesheet" href="/media/css/mixins.less" type="text/less" />
    <link rel="stylesheet" href="/media/css/home.less" type="text/less" />
    <link rel="stylesheet" href="/media/css/foo.css" type="text/css" />
{% endcompress %}

Will concatenate the .less files so the less precompiler will properly process all the files
This provides a fix for #30

setting the option 'group_first=true' in the template tag (requires django-compressor#285) will cause files of like type to be concatenated before being handed to precompilers/filters.  This will allow people to do standard code decomposition with things like less files (having a mixins file separate from page-specific files)
@travisbot
Copy link

This pull request fails (merged cb428ee into 3723a67).

@jannon
Copy link
Author

jannon commented Jul 17, 2012

okay...it looks like there hasn't been a successful build since flake8 released 1.4 with pep8 1.2 compatibility. Apparently it's got some extra conventions that the existing django_compressor codebase was not prepared for

@jannon jannon closed this Jul 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants