feat(mac): ✨ use quick look for image popups #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrski
force-pushed
the
feat/use-quick-look
branch
2 times, most recently
from
ab0ed44
to
cfcb991
Compare
|
Huge win. A major next step would be making the images focusable, so users can Tab between them and press Space to trigger Quick Look views. |
|
Thanks for the PR. I have plans to build it for windows and other OS as well. Can we only use quick look when its macOS |
|
This is exactly what I did, I check the platform and use quick look only on mac, all others use the old popup window.
|
divamgupta
reviewed
Oct 2, 2022
| @@ -3,7 +3,7 @@ | |||
| <div class="animatable_content_box "> | |||
|
|
|||
| <div v-if="Object.values(app_state.history).length > 0"> | |||
| <div v-for="history_box in Object.values(app_state.history).reverse()" :key="history_box.key" style="clear: both;"> | |||
| <div v-for="history_box in Object.values(app_state.history)" :key="history_box.key" style="clear: both;"> | |||
There was a problem hiding this comment.
I must have made a mistake while rebasing
There was a problem hiding this comment.
BTW why history is stored as an object with random keys instead of array?
piotrski
force-pushed
the
feat/use-quick-look
branch
from
cfcb991
to
27a667e
Compare
|
Fixes #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use system quick look to preview images instead of custom popup