feat: enable specifying harbor as remote domain in REGISTRY_PROXY_REMOTEDOMAIN #4342
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/proxy
…OTEDOMAIN distribution#4340 Signed-off-by: kahirokunn <okinakahiro@gmail.com>
milosgajdos
reviewed
May 8, 2024
Comment on lines
+242
to
+244
| if remoteURL.Path == "" || remoteURL.Path == "/" { | ||
| remoteURL.Path = "/v2/" | ||
| } |
There was a problem hiding this comment.
If we're gonna do something like that we should make the path configurable in proxy.
There was a problem hiding this comment.
That's certainly true.
I'll try to implement it with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the ability to specify Harbor as the remote domain in the
REGISTRY_PROXY_REMOTEDOMAINconfiguration. Previously, the proxy registry defaulted the remote URL path to/v2/unconditionally. This update ensures the path defaults to/v2/only when no other path has been set, allowing for greater flexibility in configuring remote domains such as Harbor.Changes
proxyregistry.goto conditionally set the default path to/v2/only if it is either unset or set to the root/.Motivation
This enhancement facilitates users who are integrating Harbor with our proxy registry system by allowing more precise control over the remote domain settings. It ensures that the proxy can effectively communicate with a Harbor backend by accommodating custom URL paths.