[release/2.8 backport] deprecate ReadSeekCloser in favor of io.ReadSeekCloser #4244
Conversation
Embed the interface that we're mocking; calling any of it's methods that are not implemented will panic, so should give the same result as before. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 2cd52d5) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Go's io package in stdlib now defines this interface, so we can switch to using that instead. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 019ead8) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…Closer General convention is to define interfaces on the receiver side, and to return concrete types. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit d71ad5b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Remove some intermediate variables, and use struct literals instead. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 1d8cd5e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Seb, do we want to bother with another 2.8 release? It'll be minimal if we do, delivering negligible value to users 🤷♂️ not sure if worth it |
|
do we need this for v2.8? We should maintain this branch for CVE or bug? |
|
The idea is to remove these in main (v3), but to have this branch to give users currently using v2 a "heads-up" that if they're using these, they are deprecated and to be removed; |
For the binaries, I think that makes sense; for the module, we may have to consider keeping the branch "maintained" for some time; there's various projects that use the current release as a dependency as part of LTS branches. Moving those LTS branches to a new major release is not without consequences. |
I see what you mean here but I do not like the idea of this at all - ideally we gently "force" people to migrate to v3 otherwise they won't do a thing - that's my general professional experience, not necessarily related to this project |
backport of:
relates to:
back porting these so that (if another 2.8.x patch release is done), we can give a warning out to users that this will be removed in v3