Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HTTP2 for unencrypted HTTP #4242

Closed

Conversation

erezrokah
Copy link
Contributor

Draft proposal for #4241 (currently intended for v2 releases).
Had to update some dependencies for this to work

You can test via:

docker build . -t registry:v2-h2c
docker run -p 5000:5000 registry:v2-h2c

Then on a separate shell:

curl -i --http2-prior-knowledge http://localhost:5000 
HTTP/2 200 
cache-control: no-cache
content-length: 0
date: Fri, 05 Jan 2024 15:40:04 GMT

curl -i http://localhost:5000
HTTP/1.1 200 OK
Cache-Control: no-cache
Date: Fri, 05 Jan 2024 15:40:31 GMT
Content-Length: 0

Signed-off-by: erezrokah <erezrokah@users.noreply.github.com>
@erezrokah
Copy link
Contributor Author

Help from the maintainers on the failing CI is appreciated

@milosgajdos
Copy link
Member

Is there any reason why are you opening the PR from the cloudquery repo?

Judging by the error message I smell some signing key issues -- though I presume this shouldn't matter I can't think of anything else other than some key shenanigans at the moment.

Any ideas @crazy-max ?

Also, weird that only 3 workflows have been triggered 🤨

@erezrokah
Copy link
Contributor Author

erezrokah commented Jan 9, 2024

Is there any reason why are you opening the PR from the cloudquery repo?

No strong reason, I re-opened #4246 from my personal account and also added another commit to make this opt-in to avoid what could be a breaking change

@erezrokah
Copy link
Contributor Author

Closing in favor of #4246

@erezrokah erezrokah closed this Jan 9, 2024
@erezrokah erezrokah deleted the feat/allow_h2c branch January 9, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants