Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove disabling of multipart combine small parts #4193

Merged
merged 2 commits into from Dec 19, 2023

Conversation

milosgajdos
Copy link
Member

This reverts #3556

This feature is currently broken and requires more fundamental changes in the S3 driver. Until then it's better to remove it.

See #3940 for more detail about why we're doing this.

This reverts distribution#3556

This feature is currently broken and requires more fundamental changes
in the S3 driver. Until then it's better to remove it.

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Copy link
Collaborator

@corhere corhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

docs/content/storage-drivers/s3.md Outdated Show resolved Hide resolved
Co-authored-by: Cory Snider <corhere@gmail.com>
Signed-off-by: Milos Gajdos <milosgajdos83@gmail.com>
@milosgajdos
Copy link
Member Author

PTAL @Jamstah @thaJeztah

Copy link
Collaborator

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 4a360f9 into distribution:main Dec 19, 2023
15 checks passed
@milosgajdos milosgajdos deleted the remove-combine-smallpart branch December 19, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants