[release/2.8 backport] Ignore self reference object on empty prefix #4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a given prefix is empty and we attempt to list its content AWS returns that the prefix contains one object with key defined as the prefix with an extra "/" at the end. e.g. If we call ListObjects() passing to it an existing but empty prefix, say "my/empty/prefix", AWS will return that "my/empty/prefix/" is an object inside "my/empty/prefix" (ListObjectsOutput.Contents). This extra "/" causes the upload purging process to panic. On normal circunstances we never find empty prefixes on S3 but users may touch it. Signed-off-by: Ricardo Maraschini <rmarasch@redhat.com> Signed-off-by: Antoine Cotten <hello@acotten.com>
antoineco
force-pushed
the
backport-3302
branch
from
5a96fbb
to
179aeaf
Compare
sarahactisdano
approved these changes
Oct 18, 2023
|
With https://github.com/distribution/distribution/releases/tag/v3.0.0-alpha.1 out I'm inclined to close this PR as it won't be merged into |
|
For anyone bitten by this (and not wanting to upgrade to env:
- name: REGISTRY_STORAGE_MAINTENANCE_UPLOADPURGING
value: 'enabled: false'This'll basically disable the "Upload Purging", which means the bug won't be trigger - but you'll also be suppressing the UploadPurging. However, I don't know if "Upload Purging" ever worked on S3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of the following PR to the
release/2.8branch:(cherry-picked from commit 87cbd09)
Without this fix, the S3 backend causes the registry to crash immediately after starting PurgeUploads.
This affects downsteams like https://github.com/goharbor/harbor (which I am a user of, but not speaking for).
References: