Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #3820 failed to make validate-git in local env #4094

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Dec 29, 2022

  1. fix for issue distribution#3820 failed to make validate-git in local env

    On running make validate-git
    On my local mac cloned from the main brunch
    Seems the default for the variable at "docker-bake.hcl"
    COMMIT_RANGE = ""
    Is causing the make command to exit with error:
    COMMIT_RANGE required
    This is set with correct values in the git actions process, and pass.
    But should also be executed and pass in local env.
    
    Solution:
    updating the default in the docker-"bake.hcl" file as naive value of `HEAD..HEAD`
    and overriding it with local env values from the "Makefile".
    
    in addition adding the "coverage.txt" file to the git ignore so it will not get checked in.
    
    Signed-off-by: alik42 <alik.rogotner@gmail.com>
    alik42 committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    11428c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Merge branch 'main' into fix/issue-3820-validate-git_fails_in_local_e…

    …nvironmnt
    
    Signed-off-by: Alik <120061088+alik42@users.noreply.github.com>
    alik42 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a87a546 View commit details
    Browse the repository at this point in the history