Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Basic authentication to upstream registry in proxy mode #3256

Closed
wants to merge 1 commit into from
Closed

Implement Basic authentication to upstream registry in proxy mode #3256

wants to merge 1 commit into from

Conversation

ArthurMelin
Copy link

@ArthurMelin ArthurMelin commented Sep 23, 2020

This implements HTTP Basic authentication when using the registry as a proxy to another upstream registry that is private.

Fixes #3081
Fixes #3153

@ArthurMelin
Copy link
Author

Fixes #3081 and #3153

Base automatically changed from master to main January 27, 2021 15:51
@liangyuanpeng
Copy link

@wy65701436 @milosgajdos Please take a look for this PR.

@milosgajdos
Copy link
Member

We have recently changed the GH workflow names so this needs to be rebased otherwise the tests won't run. /cc @Elassyo

Signed-off-by: Arthur MELIN <arthurmelin@tresorio.com>
@ArthurMelin
Copy link
Author

@milosgajdos Done, I made a mistake and used Github fetch upstream button but I rebased manually and force pushed afterwards, is it good now?

@codecov-commenter
Copy link

Codecov Report

Merging #3256 (7b67e0f) into main (01f589c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3256      +/-   ##
==========================================
- Coverage   56.38%   56.38%   -0.01%     
==========================================
  Files         102      102              
  Lines        7324     7325       +1     
==========================================
  Hits         4130     4130              
- Misses       2541     2542       +1     
  Partials      653      653              
Impacted Files Coverage Δ
...tribution/distribution/registry/proxy/proxyauth.go 0.00% <0.00%> (ø)
...ution/distribution/registry/proxy/proxyregistry.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f589c...7b67e0f. Read the comment docs.

@ArthurMelin ArthurMelin closed this Nov 8, 2021
@bagges
Copy link

bagges commented May 5, 2022

Why was this closed but not merged?

@masterkain
Copy link

just spent few hours trying to understand why I could not pull images through my proxy pointing to my private registry with http basic, that might explain it. why was this closed, are there updates elsewhere?

as a side note the proxy mode did work with the fairly new github packages containers registry, so I guess they are not using http basic anymore?

@milosgajdos
Copy link
Member

Why was this closed but not merged?

As you may have noticed, the author closed this PR -- we can merge things without their letting us.

as a side note the proxy mode did work with the fairly new github packages containers registry, so I guess they are not using http basic anymore?

That's a question for GH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants