Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use custom cache provider #2580

Closed
wants to merge 1 commit into from

Conversation

legionus
Copy link
Contributor

Add the ability to define a custom cache backends. Not only redis and inmemory.

Signed-off-by: Gladkov Alexey <agladkov@redhat.com>
@codecov
Copy link

codecov bot commented May 10, 2018

Codecov Report

Merging #2580 into master will decrease coverage by 9.76%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2580      +/-   ##
=========================================
- Coverage   60.87%   51.1%   -9.77%     
=========================================
  Files         129     130       +1     
  Lines       11876   11898      +22     
=========================================
- Hits         7229    6081    -1148     
- Misses       3744    5054    +1310     
+ Partials      903     763     -140
Impacted Files Coverage Δ
registry/storage/cache/provider/cacheprovider.go 0% <0%> (ø)
registry/handlers/app.go 46.88% <0%> (-0.83%) ⬇️
registry/storage/driver/gcs/gcs.go 0.39% <0%> (-68.67%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-56.91%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-51.14%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.15% <0%> (-50.98%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83389a1...58c8dd7. Read the comment docs.

Base automatically changed from master to main January 27, 2021 15:51
@milosgajdos
Copy link
Member

@legionus mind rebasing?

@legionus
Copy link
Contributor Author

@legionus mind rebasing?

@milosgajdos I made this PR 5 years ago. I stopped developing distribution a long time ago. If you do not see any benefit in this PR, then you can close it.

@milosgajdos
Copy link
Member

Gotchya. I can take it over from here and rebase to a new PR. Let's keep it open for now if you dont mind. Thanks!

@legionus
Copy link
Contributor Author

I don't mind :)

@milosgajdos
Copy link
Member

Closing in favour of #4169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants