Make serde optional
#3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the `serde` dependency optional to reduce the total number of them from 57 to 51 using `--no-default-features` flag. Also for simpler maintainablity, moved `SerializableProof` into separate `serializable` modules, so by placing `#[cfg(feature = "serde")]` above it's declaration the whole implementations and structures became optional (instead of placing `#[cfg(feature = "serde")]` above each of them). Removed usage of `serde` inside tests for more prefered `Debug` implementations.
|
Conflicts with #2 as some of the code was updated in the tests |
|
It will be great to add checks and tests with |
Velnbur
force-pushed
the
feature/opt-serde
branch
from
f5d0997
to
d31860a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
serdedependency optional to reduce the total number of dependencies from 57 to 51 using--no-default-featuresflag.Also for simpler maintainablity, moved
SerializableProofinto separateserializablemodules, so by placing#[cfg(feature = "serde")]above it's declaration the whole implementations and structures became optional (instead of placing#[cfg(feature = "serde")]above each of them).Removed usage of
serdeinside tests for more preferedDebugimplementations.