refactor: Fully QML GUI as separate target executable #1894
Conversation
RobBuchananCompPhys
force-pushed
the
qml-gui-target
branch
from
bac99db
to
a803ec3
Compare
There was a problem hiding this comment.
I haven't had a chance to take a good look at the actual C++ (I'll do that after lunch), but this rewrite is a great opportunity to drop a ton of link time dependencies that we won't really need. I've gone through and pruned it down a bit, with some suggestions on how to do a little more.
Great, thanks for looking into it. @rprospero do we need to look at restoring some of those dependencies to fix the macos build? |
|
Just a record of where I'm at on this.
There's three possible routes forward from here
I've listed the options in the order that I will attempt them. |
src/dissolve-gui-qml.cpp
Outdated
| if (options.inputFile()) | ||
| // loadSuccessful = dissolveWindow.loadInputFile(options.inputFile().value()); |
There was a problem hiding this comment.
Since we've commented out the actual action, this if statement will act on the next statement. Granted, that is also another conditional that tests the same condition, but it might be better to comment out or remove the condition.
There was a problem hiding this comment.
We'll need it eventually probably, so I'd vote for commenting the condition out.
| // Ensure that the C locale is set, otherwise printf() and friends may not use dot for the radix point | ||
| setlocale(LC_NUMERIC, "C"); | ||
| QLocale::setDefault(QLocale::C); | ||
|
|
||
| // Print GPL license information | ||
| Messenger::print("Dissolve-GUI-QML {} version {}, Copyright (C) 2024 Team Dissolve and contributors.\n", Version::appType(), | ||
| Version::info()); | ||
| Messenger::print("Source repository: {}.\n", Version::repoUrl()); | ||
| Messenger::print("Dissolve comes with ABSOLUTELY NO WARRANTY.\n"); | ||
| Messenger::print("This is free software, and you are welcome to redistribute it under certain conditions.\n"); | ||
| Messenger::print("For more details read the GPL at <http://www.gnu.org/copyleft/gpl.html>.\n"); |
There was a problem hiding this comment.
It might be useful to put this boilerplate for in a method on the Dissolve class. You could pass in the program name and it could do this generic setup. Granted, we don't have to do it on this PR, but it might be worth flagging the issue.
This PR takes on board the comments and discussion over the previous attempt to start a QML GUI for Dissolve.
The idea is now to go with a separate executable, with entrypoint in
dissolve-gui-qml.A couple of lines have been commented out in
mainwhere thedissolveWindowobject was used while I figure out how to proceed with the CLI options parsing using a pure QML window, rather than Qt Widgets (basically, trying to make it work for now).Additionally, the CMake files almost certainly link far more dependencies for the new QML-based executable than is necessary, so over time we should aim to identify what is not needed and remove from the list.