Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove atom type and master term from forcefield tab #1889

Merged
merged 16 commits into from
May 13, 2024
Merged

fix: Remove atom type and master term from forcefield tab #1889

merged 16 commits into from
May 13, 2024

Conversation

RobBuchananCompPhys
Copy link
Contributor

@RobBuchananCompPhys RobBuchananCompPhys commented May 2, 2024 •
edited

Closes #1065, Closes #1874, Closes #1586

@RobBuchananCompPhys RobBuchananCompPhys changed the title Fix/remove atom type master term fix:remove atom type master term May 2, 2024
@RobBuchananCompPhys RobBuchananCompPhys changed the title fix:remove atom type master term fix: remove atom type master term May 2, 2024
@RobBuchananCompPhys RobBuchananCompPhys changed the title fix: remove atom type master term fix: Remove atom type and master term from forcefield tab May 2, 2024
@RobBuchananCompPhys RobBuchananCompPhys marked this pull request as ready for review May 2, 2024 14:17
trisyoungs
trisyoungs reviewed May 3, 2024
View reviewed changes
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close. Just a bit of tweaking required!

src/gui/forcefieldTab.cpp Show resolved Hide resolved
src/gui/forcefieldTab.cpp Outdated Show resolved Hide resolved
trisyoungs
trisyoungs approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a bit of cleanup / ordering of operations as detailed in the comment.

src/gui/forcefieldTab.cpp Outdated Show resolved Hide resolved
@RobBuchananCompPhys RobBuchananCompPhys merged commit 420d363 into develop May 13, 2024
9 checks passed
@RobBuchananCompPhys RobBuchananCompPhys deleted the fix/remove-atom-type-master-term branch May 13, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisyoungs trisyoungs trisyoungs approved these changes

@rprospero rprospero Awaiting requested review from rprospero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot delete Atom Type and Master Terms Cannot remove Atom Types Remove Master Terms from GUI
2 participants
@RobBuchananCompPhys @trisyoungs