Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Buckingham potential and Guassian FD #1885

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

Danbr4d
Copy link
Contributor

@Danbr4d Danbr4d commented Apr 25, 2024

Closes #247 .

@Danbr4d Danbr4d requested a review from trisyoungs April 25, 2024 08:59
@Danbr4d Danbr4d self-assigned this Apr 25, 2024
@Danbr4d Danbr4d changed the base branch from develop to refactor-function1d April 25, 2024 10:59
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. There is a new unit test somewhere focussing on pair potentials - to ensure the forces etc are correct it would be worth adding Buckingham to it.

@Danbr4d Danbr4d changed the title feat: Add Buckingham potential feat: Add Buckingham potential and Guassian FD Apr 29, 2024
@Danbr4d Danbr4d requested a review from trisyoungs April 29, 2024 13:56
Base automatically changed from refactor-function1d to develop May 14, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buckingham potentials
2 participants