New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable atom type and master term remove functionality #1883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisyoungs
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. However there are a couple of "propagation" mechanics to consider.
- When removing an AtomType we are currently being saved (or perhaps being obscured from problems...) by our use of
std::shared_ptr
both in the main vector of AtomTypes as well as any classes which need it. A bigger discussion which arises from this is "Should we really be using something likestd::weak_ptr
to store references to anAtomType
? For now, those references must be nullified by extending theobjectNoLongerValid
andremoveReferenceTo
template functions (seeCoreData
). - Removing a master term suffers from a similar problem to the AtomType, but when removed we should simply convert any uses into Species-local definitions (i.e. copy the data into a new
SpeciesBond
etc.)
Seems that there's a fair bit more work here than anticipated!
RobBuchananCompPhys
changed the title
enable atom type and master term remove buttons, connect
fix: enable atom type and master term remove functionality
Apr 29, 2024
trisyoungs
reviewed
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1065, Closes #1874, Closes #1586