refactor: Rework Function1D, add derivatives #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisyoungs
force-pushed
the
clarify-forces-and-derivatives
branch
from
9cc4082
to
b573b95
Compare
…onPotential<> requirements.
… force calculation in PairPotentials.
trisyoungs
force-pushed
the
refactor-function1d
branch
from
c8a1e46
to
78d3852
Compare
rprospero
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors and repurposes the
Function1Dclass into a more usable form, and allows it to be used as the primary source for pairpotential function implementation, moving that responsibility out of thePairPotentialclass itself.