feat: Allow setting of temperature through button & update docs #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
trisyoungs
requested changes
Apr 15, 2024
trisyoungs
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Sorry - sent you a message on Teams expressing how bad I got this wrong. Made way more work for you than it should have been!
I just tried the signal connection, and for me adding this in the ConfigurationTab constructor worked just fine, and lets you simplify your PR quite a bit:
connect(ui_.TemperatureToolButton, SIGNAL(clicked(bool)), dissolveWindow_, SLOT(on_ConfigurationAdjustTemperatureAction_triggered(bool)));
rhinoella
changed the title
|
@trisyoungs Please double-check the changes to the Sillica example, I am not entirely sure if the node is appropriate for this example. |
trisyoungs
requested changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes depreciated
TemperatureProcedureNodeand instead sets temperature through a toolbutton in the configuration tab.