Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for untagged in DocumentDecoderSchemaVisitor #1446

Merged
merged 3 commits into from Mar 18, 2024

Conversation

lewisjkl
Copy link
Contributor

There may be a reason why we didn't have this before, but we came across a case that seems to indicate this was overlooked. We already had support for encoding untagged unions from documents, but not decoding them. Feel free to close this if I missed something and there actually is a good reason to omit them.

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

Copy link
Contributor

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, surprising we just find out that we did not support this!

thanks for the fix

@Baccata Baccata merged commit 141bf99 into series/0.18 Mar 18, 2024
11 checks passed
@Baccata Baccata deleted the add-untagged-document-decoder branch March 19, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants