Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect enum values ordering #1437

Merged
merged 4 commits into from Mar 12, 2024
Merged

Respect enum values ordering #1437

merged 4 commits into from Mar 12, 2024

Conversation

Baccata
Copy link
Contributor

@Baccata Baccata commented Mar 12, 2024 •
edited

  • Amend rendering logic to respect the ordering of enum values in rendered enumeration.
  • Amend dynamic enum schema compilation to respect the ordering of enum values.

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Updated dynamic module to match generated-code behaviour
  • Updated changelog

@Baccata
Respect enum values ordering
abc26f0 
Amend rendering logic to help guarantee the ordering of enum values
in rendered enumeration.

Add a property test to check it.
@Baccata
Ensure that dynamic enum schemas respect original ordering
b24bb69
@Baccata
Amend wording of changelog
b3cf4f9
@Baccata
Make scala 3 happy
e78d261
@Baccata Baccata mentioned this pull request Mar 12, 2024
Merged
4 tasks
@Baccata Baccata requested a review from kubukoz March 12, 2024 13:30
@Baccata Baccata merged commit 3616665 into series/0.18 Mar 12, 2024
11 checks passed
@Baccata Baccata deleted the guarantee-enum-ordering branch March 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubukoz kubukoz kubukoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Baccata @kubukoz