Define unknownFieldRetention trait #135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daddykotex
reviewed
Feb 21, 2024
| .build() | ||
|
|
||
| val model = | ||
| Model.assembler.disableValidation |
There was a problem hiding this comment.
any reason why we have to disable validation?
There was a problem hiding this comment.
Not sure, I based this spec on one of the existing ones which had this. I'll see what happens if I enable it.
dhpiggott
force-pushed
the
define-unknown-field-retention-trait
branch
from
4417d9e
to
739f418
Compare
dhpiggott
force-pushed
the
define-unknown-field-retention-trait
branch
from
739f418
to
a741ba6
Compare
dhpiggott
commented
Mar 11, 2024
| @trait( | ||
| selector: "structure > member :test(> document)" | ||
| ) | ||
| structure unknownJsonFieldRetention {} |
There was a problem hiding this comment.
From @Baccata via Slack:
just unify the two traits as jsonUnkown. Document abides by json semantics, and we do implement the same semantics in both Document and jsoniter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.