FIX: backtracking re-render assertion in future-date-input #13075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaffeux
approved these changes
May 17, 2021
AndrewPrigorshnev
changed the title
AndrewPrigorshnev
deleted the
fix/backtracking-rerender-asserion-in-future-date-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See more details from the Ember team here.
We call
_updateInputfrominit._updateInputtriggersonChangeInputwhich mutates a date that was given tofuture-date-inputjust a moment ago and a rendering cycle wasn't finished yet.I ran into this assertion when modifying the Slow Mode dialog when working on FIX: slow mode dialog doesn't remember Enabled Until value.
It didn't break any test so far and I didn't find regressions; I will deal with regressions it may cause.