Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: merge votes regardless of voters' visibility #187

Merged
merged 1 commit into from
May 2, 2024

Conversation

renato
Copy link
Contributor

@renato renato commented Apr 30, 2024

Ensures merging topics also merge votes regardless of the voters' visibility (when voting_show_who_voted site setting is false), bypassing this check from the previously used orig.who_voted:

def who_voted
return if !SiteSetting.voting_show_who_voted
self.votes.map(&:user)

@renato renato merged commit 0ae9350 into main May 2, 2024
5 checks passed
@renato renato deleted the fix_merge_votes_hide_who_voted branch May 2, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants