Allow scheduling publication of Full Topic first post #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
reviewed
May 17, 2024
| @@ -32,7 +32,6 @@ def unschedule | |||
| protected | |||
|
|
|||
| def ensure_first_post | |||
| return render_post_error("first_post_not_enabled", 403) unless @post.activity_pub_first_post | |||
| render_post_error("not_first_post", 422) unless @post.activity_pub_is_first_post? | |||
There was a problem hiding this comment.
render_post_error("not_first_post", 422) unless @post.activity_pub_is_first_post?
I'm not sure this PR is opening up publication scheduling to all posts, looks like we still check for @post.activity_pub_is_first_post?.
Or I guess, it opens up scheduling for the first post for categories with Full Topic publication configured?
There was a problem hiding this comment.
Yeah, we don't want to open it up to replies just yet as that introduces other issues. That'll be a separate PR. This is the first step, i.e. allowing for scheduling Full Topics if the entire topic is not yet published.
pmusaraj
changed the title
pmusaraj
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.