Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Add defaultValues to respective select menu components data #10265

Merged
merged 4 commits into from May 13, 2024

Conversation

fronkdev
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Added 'defaultValues' typings on ChannelSelectMenuComponentData, RoleSelectMenuComponentData, and UserSelectMenuComponentData.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

Added 'defaultValues' typings for ChannelSelectMenuComponentData, RoleSelectMenuComponentData, and UserSelectMenuComponentData.
@fronkdev fronkdev requested a review from a team as a code owner May 10, 2024 14:04
Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 1:24pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 1:24pm

@Jiralite Jiralite changed the title Update index.d.ts types: Add defaultValues to respective select menu components data May 10, 2024
packages/discord.js/typings/index.d.ts Show resolved Hide resolved
Adding 'defaultValues' typing to MentionableSelectMenuComponentData
@Jiralite Jiralite added this to the discord.js 14.15.3 milestone May 10, 2024
@Jiralite Jiralite dismissed their stale review May 13, 2024 13:22

Resolved.

@kodiakhq kodiakhq bot merged commit c2432d5 into discordjs:main May 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants