Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip flaky rest test #10234

Merged
merged 1 commit into from Apr 27, 2024
Merged

test: skip flaky rest test #10234

merged 1 commit into from Apr 27, 2024

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Apr 27, 2024

Please describe the changes this PR makes and why it should be merged:
A bump in undici's version has broken this particular test (since 6759f5b)

Status and versioning classification:

Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Apr 27, 2024 4:24pm
discord-js-guide ⬜️ Ignored (Inspect) Apr 27, 2024 4:24pm

@vladfrangu
Copy link
Member

I'd also like to maybe report / checkin with Undici peeps about this

@iCrawl iCrawl merged commit dc8f149 into main Apr 27, 2024
7 checks passed
@iCrawl iCrawl deleted the test/skip-flaky-test branch April 27, 2024 17:11
Vylpes pushed a commit to Vylpes/card-drop that referenced this pull request May 20, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@discordjs/rest](https://discord.js.org) ([source](https://github.com/discordjs/discord.js)) | dependencies | minor | [`2.2.0` -> `2.3.0`](https://renovatebot.com/diffs/npm/@discordjs%2frest/2.2.0/2.3.0) |

---

### Release Notes

<details>
<summary>discordjs/discord.js (@&#8203;discordjs/rest)</summary>

### [`v2.3.0`](https://github.com/discordjs/discord.js/blob/HEAD/packages/rest/CHANGELOG.md#discordjsrest230---2024-05-04)

[Compare Source](https://github.com/discordjs/discord.js/compare/@discordjs/rest@2.2.0...@discordjs/rest@2.3.0)

#### Bug Fixes

-   Anchor link for events ([0efd1be](discordjs/discord.js@0efd1be))

#### Documentation

-   Split docs.api.json into multiple json files ([597340f](discordjs/discord.js@597340f))
-   Remove hyphen after `@returns` ([#&#8203;9989](discordjs/discord.js#9989)) ([e9ff991](discordjs/discord.js@e9ff991))

#### Features

-   Local and preview detection ([79fbda3](discordjs/discord.js@79fbda3))
-   **REST:** Dynamic rate limit offsets ([#&#8203;10099](discordjs/discord.js#10099)) ([278396e](discordjs/discord.js@278396e))

#### Refactor

-   Docs ([#&#8203;10126](discordjs/discord.js#10126)) ([18cce83](discordjs/discord.js@18cce83))
-   Use interfaces for AsyncEventEmitter event maps ([#&#8203;10044](discordjs/discord.js#10044)) ([adfd9cd](discordjs/discord.js@adfd9cd))

#### Styling

-   Fix up lint ([d869d9b](discordjs/discord.js@d869d9b))

#### Testing

-   Skip flaky rest test ([#&#8203;10234](discordjs/discord.js#10234)) ([dc8f149](discordjs/discord.js@dc8f149))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

Reviewed-on: https://git.vylpes.xyz/External/card-drop/pulls/232
Reviewed-by: Vylpes <ethan@vylpes.com>
Co-authored-by: Renovate Bot <renovate@vylpes.com>
Co-committed-by: Renovate Bot <renovate@vylpes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants