Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update tsconfig to address type checking issues #10104

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix: Update tsconfig to address type checking issues #10104

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca61da9
fix: enable strictNullChecks, noEmit, and allowImportingTsExtensions …
FabricSoul Jan 27, 2024
efff8bf
Update packages/create-discord-bot/template/TypeScript/tsconfig.json
FabricSoul Jan 30, 2024
d7bd5a0
Merge branch 'main' into main
FabricSoul Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/create-discord-bot/template/TypeScript/tsconfig.json
View file
Open in desktop
almostSouji marked this conversation as resolved.
Show resolved Hide resolved
Expand Up @@ -8,6 +8,9 @@
"moduleResolution": "NodeNext",
"target": "ESNext",
"outDir": "dist",
"skipLibCheck": true
"skipLibCheck": true,
"strictNullChecks": true,
"noEmit": true,
FabricSoul marked this conversation as resolved.
Show resolved Hide resolved
"allowImportingTsExtensions": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be enabled for deno/bun, not every TS project! 👀

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense

}
}