Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oauth2): separate OAuth2 scopes #508

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vvito7
Copy link
Contributor

@vvito7 vvito7 commented Jun 29, 2022

Please describe the changes this PR makes and why it should be merged:
Separates OAuth2Scopes into OAuth2PublicUserScopes, OAuth2GuildScopes, OAuth2OtherScopes, OAuth2RestrictedUserScopes and OAuth2PrivateUserScopes.

Note
Should I add a description to each new enum? For example:
image

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel
Copy link

vercel bot commented Jun 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-api-types ✅ Ready (Inspect) Visit Preview Jun 30, 2022 at 10:48AM (UTC)

@vladfrangu
Copy link
Member

Note
Should I add a description to each new enum? For example:
image

Yes please! Ideally links + short descriptions (just like how docs have it)

deno/payloads/v10/application.ts Outdated Show resolved Hide resolved
kyranet
kyranet previously approved these changes Jun 29, 2022
vladfrangu
vladfrangu previously approved these changes Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants