-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COMMISSION] New mech weapons: club, bow & BFG #8486
base: master
Are you sure you want to change the base?
[COMMISSION] New mech weapons: club, bow & BFG #8486
Conversation
…into mech_club_bow_bfg
…into mech_club_bow_bfg
…into mech_club_bow_bfg
Screenshots? |
if(. && ismech(loc) && istype(target) && target != owner) | ||
if(flail_mode) | ||
target.visible_message(SPAN_DANGER("[target] gets slammed by [src]'s [holding]!"), SPAN_NOTICE("You get slammed by [src]'s [holding]!"), "You hear something soft hit a metal plate!", 6) | ||
target.Weaken(5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weaken is a stun that slows movement to a crawl and prevents fighting back, which we might have problems with if it can be applied repeatedly. A different system like recoil can apply slowdown, while also having a capacity to disarm someone. It might be preferable here.
/obj/item/mech_equipment/mounted_system/mace/resolve_attackby(mob/living/target, mob/user, params) | ||
if(ishuman(target)) | ||
var/mob/living/carbon/human/targ = target | ||
if(targ.stats.getStat(STAT_VIG) > STAT_LEVEL_EXPERT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flat stat check? Shouldn't there be a Prob()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would usually agree with it, but we should avoid any kind of RNG in PvP (it is PvP). This is fine currently, or the damage can just start to decrease after certain VIG (so example: godlike req (80 iirc) at 40 VIG it starts to decrease, at 60 VIG damage is halved, at 79 you get like 2 brute; The mace barely grazes you!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the weapon have no effect though is definitely not fine.
About The Pull Request
Remake of #8456, with permission from the author.
Adds 3 new mech weapons:
Why It's Good For The Game
More weapon variety, as well as some integration with the materials system.
Testing
Unfortunately cannot test, as this server appears to be non-515-compliant.
Changelog
🆑 Cheesepizza2, Doster-D
add: Added a new mech weapon: the NT "Warhead" mace! In its mace mode, it will absolutely obliterate structures and people. Using it in hand will convert it to a flail that does less damage but has a longer range and weakens + knocks back targets.
add: Added a new mech weapon: the BFG! After a lengthy charging period, this massive cannon shoots a massive bolt of plasma energy that does loads of damage in a wide radius.
add: Added a new mech weapon: the mounted crossbow! Insert in materials to load as crossbow bolts - the harder and heavier the material, the more armor penetration and damage it has respectively.
/:cl: