-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links Security Status to Sechuds #8467
base: master
Are you sure you want to change the base?
Links Security Status to Sechuds #8467
Conversation
Links sec records to sechuds
Failed integration test, L bozo |
Intergration failed?? why don't you go inter into some bitches homes. |
I am not a crook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Records appeared as normal
How does it work with old chat (believe it or not, it needs to work with old chat), how it works if record contain Details (stuff you add in character setup)?
Anything added to security status in setup will appear let me check it in old chat rq tho should still be fine |
still works with Old chat but the some of the HTML code like boxes don't show up properly. otherwise works as normal |
Screenshots please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So? Make them disappear. |
Allright it's gone poof |
Co-authored-by: SirRichardFrancis <65828539+SirRichardFrancis@users.noreply.github.com>
As a matter of fact, I can't find the code responsible for this, since text from your screenshots does not appear to be in the build, and neither is added by this PR. |
Im positive which text are you referring to ? |
If you made that table in your character's records, then this is nonsensical feature presentation. |
I mean how would you expect me to show it off this is quite literally one of the end results of editing the security records. |
|
Note for maintainers , someone should really check if sec records are actually sanitized in the field that this PR outputs , else someone could inject JS. |
Co-authored-by: SirRichardFrancis <65828539+SirRichardFrancis@users.noreply.github.com>
read var deleted
why is this conflicting? |
Merge conflicts still present. |
About The Pull Request
This PR links the security record. field from crew records to sechuds allowing them to be seen by those wearing sechuds
Why It's Good For The Game
Allows for much Better in field keeping up to date with incidents. and problems without having to run to a computer every
single time just to see a person's history.
Testing
spawned in as operative.
edited secrecords from console
viewed myself with sechuds
Records appeared as normal
Changelog
馃啈
tweak: sechuds now draw their information from the crew record program.
/:cl: