Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault: Loadout-based Activity Reward System #8305

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

Doster-d
Copy link
Contributor

@Doster-d Doster-d commented Sep 13, 2023

About The Pull Request

This pull request adds the Vault.
Each player has their own individual Vault, where some items (not exactly objects, can be perks) from the previous round are stored.
The player can take them in round for wish (currently cost 1 loadout points, to be change)
In addition (there will be) a link to a donation system (Patreon), whose members will be able to conduct transactions over iriski more favorably than regular players.
On the round end the player can choose the item he wish to take from static list by spending iriski on it (reward menu).

Selection items for round start:
image

Reward menu:
image

TODO LIST

  • Persistence System (Load & Save test included)
  • Vault Basics (currency, buy/sell actions, ckey-based items)
  • DB&Patreon integration
  • Integration test systems
  • Metric Collection
  • Rewarding menu
  • Vault Content
  • Massive Test (if possible)

Why It's Good For The Game

Players get rewarded for their play and stay longer with us

Testing

The following tests were conducted:

  • Buying and selling items
  • Attempting to go negative on Iriski
  • Loading and unloading items

Changelog

🆑
add: Vault Loadout-based Activity Reward System is now active. You can earn points (iriski) and buy some items and perks!
/:cl:

@SirRichardFrancis
Copy link
Contributor

(Patreon), whose members will be able to conduct transactions over iriski more favorably than regular players.

I thought giving patrons gameplay advantage over rest of the player base was a huge no-no, but apparently that have changed.

@Mycah142
Copy link
Contributor

Fuck the poor.

@Doster-d
Copy link
Contributor Author

I thought giving patrons gameplay advantage over rest of the player base was a huge no-no, but apparently that have changed.

But it's not gameplay advantage (in my opinion), for example you have item that costs 5 iriski, if you're patron you can sell it for 7 iriski.

However the amount of discount and the discount itself is subject to change.

@Benblu
Copy link
Contributor

Benblu commented Sep 14, 2023

Remove the patron discount and maybe this will actually be palatable.

@thevandie
Copy link
Contributor

thevandie commented Sep 14, 2023

there's like 5 problems (with solutions) to this

  1. People are gonna carry over crazy shit like dallases or bloodred voids from previous rounds, and the roundstart balance is gonna be FUCKED
  2. People are gonna break the game by carrying over one-time items like faction artifacts
  3. Carrying antag exclusive items over from previous rounds would be FUCKED, cause it'd mean you literally have zero idea who a traitor is and who isn't, where-as currently we at least have a small idea (it's still fucked, but at least you can realistically tell someone's an antag if they have an uplink).
  4. If you remove these specific items it'll delete some of the purpose to this whole idea
  5. If straight money is able to be carried over, captain has a fat stack of 2 million, and he can literally just buy ANYTHING on the ship and gain himself shitloads of iriska coins in one round. We need to nerf the captain's fortune down to something more reasonable. This is also a huge problem in general, since people get money consistently every round, so they could just buy a load of guns with that money (or keep it in their backpack each roundend) then clone it like crazy, doubling their money every round till their oil barons. Literally anyone could do that, and that sounds extremely unbalanced. Guild especially, since they're expected to get loads of cash and they're the main ones who can buy this stuff. And by the way, this is a problem even if they can't just use straight cash, because the person can say, just buy a large amount of assets that ARE transferable and clone shit that way. Basically, we'd need a fucking economy rework, unless you can come up with an INGENIUS plan to fix this issue that I'm too dumb to think of.

SO, first suggestion would be to add a banned items list. Stop some items from being carried over at all.
Second suggestion, to keep the incentive on still carrying these items over the round, maybe just turn them straight into cash for the next round, or iriska coin I guess
For example, if you hold a Dallas over, it forces you to sell it. However, it gives you a massive payout cause it's a super rare item. I suppose you could do a similar thing with completing faction and antag objectives in general, just give people money for it, but that doesn't sound like it's in the scope of the PR so I won't expand further. You should also probably equate antag items to their TC cost, so people don't just buy (for example) loads of BSDM units and absolutely game the system by getting thousands of iriska coins in one round. So instead, 1 TC should be worth the same amount no matter what it's spent on. That should also be accounted for if it's still in the uplink, btw.

TLDR, make a ban list on items you can carry over, but give uniquely massive payouts for grabbing them
like faction artifacts, any antag items, as well as rare combat items. You should also make everything that uses TC worth the same amount as the individual TeleCrystals, to avoid minmaxing equipment at the end of the round to get insane amounts of TC.

PS. fuck the poor it's funny, but yeah should probably delete the patreon bonus.

@thevandie
Copy link
Contributor

As a personal note, I actually really like this idea
I've been playing the recent Blue Colony Reborn server, and the ability to carry over items from previous rounds is an interesting concept that I enjoy
Although obviously it can't be taken to that server's extreme, since you can't just store stuff in a lot. Still, being able to carry over the same gun through your rounds is an amazing idea and I love it.

@null-Aurelian
Copy link
Contributor

well if we can force sell certain items, it might be an idea to add faction artifacts to the force-sold list, sort of like a running king of the hill for personal benefit. It incentivizes theft of artifacts without destruction by assorted randoms.

@thevandie
Copy link
Contributor

well if we can force sell certain items, it might be an idea to add faction artifacts to the force-sold list, sort of like a running king of the hill for personal benefit. It incentivizes theft of artifacts without destruction by assorted randoms.

That's literally exactly what I said

@Mycah142
Copy link
Contributor

Alternative: We use the Spawn_Blacklist as a reference of items that shouldn't be carried over, and instead of letting them be carried over, maybe they can be exchanged for coins without the player having a say? This might help avoid shenanigans. I dunno if anyone said any of this before, I saw alot of words and my eyes glazed over.

@tristain01
Copy link

Perosonally, i think this is going to break the game, be crap in the sense you cant store anything fun or some where inbetween.

@null-Aurelian
Copy link
Contributor

TBH I thought the Iriski were going to be tied to round scores and give funny/painful things like "start with a corgi" or "start with a hologun" or "sanity is capped to 0"

@Doster-d
Copy link
Contributor Author

Doster-d commented Sep 14, 2023

In the "Metric Collection and Rewarding" you will receive by calculation of your actions in the end (probably round stats) some iriski, that you can spend on saving items or perks (on my first approach I will try to settle numbers that you can save 3-4
"general" items, dubject to change).

There will be a blacklist of items, but the system in design allows you to store "fun or anything in between".

In the next round, if you don't sell this things, you will spawn with them.

The selling price will be much lower (½ of price) than price of buying (the price of item itself)

YOU CAN 'T SELECT ITEMS, THEY WILL BE SELECTED BY YOUR ACTIONS (RNG PLAYER ALARM)

Arguably you can spare iriski to get more items in your Vault at round end.

Donation p2w system:

The discount will be removed.

You can't buy iriski from real or in-game bucks. You get them by playing in game and do things that game thinks you should do (completing antag goals, your division goals)

If you're max tier you (will) currently (subject to change, bigger number to get difference in tests) have 75% more points than yf you're poor regular player

Probably it will just changed to get iriski bonus at the round end iriski giveaway, but at this stage of development I made up this system to test things.

@Firefox13
Copy link
Contributor

Firefox13 commented Sep 14, 2023

Probably it will just changed to get iriski bonus at the round end iriski giveaway, but at this stage of development I made up this system to test things.

This (iriski bonus at the round end) is a more welcome solution rather than selling price increase.

In the next round, if you don't sell this things, you will spawn with them.

Ability to store them is also intended.

YOU CAN'T SELECT ITEMS, THEY WILL BE SELECTED BY YOUR ACTIONS (RNG ALARM)

I probably should've mentioned this earlier, but it shouldn't be the items that you physically carry out.
Internally, there should be several separate lists of items for iriska vault system - perks, oddities (weak ones), guns (unlikely, very OP), fun shit that shouldn't go in loadout (paintjobs for weapons for patrons) - and use them for rewarding and internal shop.
This solves the "people will hoard ten dallases round-end or get completely nude to get that one item" issue. I really don't want that to happen.
This ALSO solves the "Ided and didn't get any items" issue.
Of course, if you died mid-round the reward will be lower but we don't want players just stop having conflict and do nothing for three hours straight to get some iriskas. How to solve this:

  1. Rewards must not be very valuable. No "extremely rare Dallas" or "+50 sanity perk".
  2. Observers simply do not get anything. To be eligible for a reward you should've played a certain portion of the round, as a human/blitz/robot/borer/any other antag (not mouse) and be there during roundend. Not necessarily alive. If round lasted for 3 hours and your character lasted for 30 minutes you should be eligible for rewards (numbers still need thinking)
    @Doster-d

@Doster-d
Copy link
Contributor Author

Okay discount will be removed closer to "Metric Collection and Rewarding" and will be replaced iriski bonus at round end.
I will be adding ability to store items indefintly asap, as well as changing some internal stuff.

@TheLeopold
Copy link
Contributor

it shouldn't be the items that you physically carry out

Then why do you call it "Vault" and not, i dunno, "Loadout 2.0"?

@Firefox13
Copy link
Contributor

Then why do you call it "Vault" and not, i dunno, "Loadout 2.0"?

that's how it's called in design doc
it also sounds really cool

@Mycah142
Copy link
Contributor

I'm going to make a thread on the discord somewhere so this git doesn't get super crowded.

@Mycah142
Copy link
Contributor

https://discord.com/channels/255035529085583360/1151870542970896384/1151870546993233990

Questions are being answered, and discussion can happen here.

@TheShown911
Copy link
Contributor

Cyberpunk enjoyers when the ritch get a gameplay advantage

@Doster-d
Copy link
Contributor Author

Doster-d commented Oct 4, 2023

Some updates that happens recently:

  • Added SQL Persisntence mode
  • Added discord bot support for adding patrons from Patreon.
  • Added discord bot support for linking
  • Added reward interface (I suck at it) to gain items.
  • Added configurations for static menu
  • Removed buying items from loadout.
  • Removed silly codes.
  • Added more silly codes.

Oh and I linked current points to rewarding, I will make some changes for it, but feel free to discuss the function that takes point and gives you the amount of iriski.

Currently for escaping alive (500 points) you will get 4 iriski, 1500 points - 5 iriski and so one (x^0.22)

@Doster-d Doster-d changed the title [WIP] Vault: Loadout-based Activity Reward System Vault: Loadout-based Activity Reward System Oct 5, 2023
@Doster-d
Copy link
Contributor Author

Doster-d commented Oct 5, 2023

gentlemen-synchronize.mp4

@Doster-d Doster-d marked this pull request as ready for review October 5, 2023 13:29
@thevandie
Copy link
Contributor

pretty sure this hasn't been looked at cause it's still at 7/8 tasks and looks unfinished (context or not)
if someone is reading the github history from discord, get on this shiet

@Doster-d
Copy link
Contributor Author

Description updated.
FireFox was informed about status of this PR 10/06/23

@thevandie
Copy link
Contributor

Based 👍

@github-actions github-actions bot added the Merge Conflict Merge Conflict label Oct 20, 2023
@hyperioo
Copy link
Contributor

Smol conflict for tgui, quick rebase and rebuilding tgui should fix it

@Doster-d
Copy link
Contributor Author

It should be done

@github-actions github-actions bot removed the Merge Conflict Merge Conflict label Oct 27, 2023
@thevandie
Copy link
Contributor

It's apparently done, don't forget, big people

@thevandie
Copy link
Contributor

It's apparently done, Firefox, hyperio and/or shown, please make sure it gets looked at Friday
I beg of thee

@Firefox13
Copy link
Contributor

The system needs content. Think of its like R&D but without any tech trees coded in. Adding it in without rewards added in and without (atleast somewhat) balanced rewards is pointless.

@Doster-d Doster-d marked this pull request as draft November 23, 2023 06:28
@github-actions github-actions bot added the Merge Conflict Merge Conflict label Dec 1, 2023
@github-actions github-actions bot removed the Merge Conflict Merge Conflict label Dec 29, 2023
@github-actions github-actions bot added the Merge Conflict Merge Conflict label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict Merge Conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet