Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Embedded App SDK doc for setOrientationLockState() #6759

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Snazzah
Copy link
Contributor

@Snazzah Snazzah commented Mar 27, 2024

Seems like this command doesn't actually need the guilds.members.read scope, and the values in the usage doesn't use strings.

Copy link
Contributor

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A table should maybe be included for the mapping from int to flag

#### Lock States
| Type | State      |
| ==== | ========== |
| 1    | Unlocked   |
| 2    | Portrait   |
| 3    | Landscape  |

#### Grid Lock States
| Type | State    |
| ==== | ======== |
| 1    | Unlocked |
| 2    | Locked   |

@colinloretz
Copy link
Contributor

@Snazzah thanks for this! I'll take a peek. These are currently manually written but will be auto-generated soon™️, so we'll have things like types/etc included in tables.

@colinloretz colinloretz self-requested a review March 27, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants