Make channel access checks consistent #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
force-pushed
the
patch/missing-access
branch
from
73b89fd
to
f37cc49
Compare
MinnDevelopment
force-pushed
the
patch/missing-access
branch
from
ffeabdd
to
0051262
Compare
mergify bot
pushed a commit
to SvenKirschbaum/musikbot-client
that referenced
this pull request
May 19, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | debian | final | digest | `155280b` -> `804194b` | | | | | | rust | stage | digest | `0dd183f` -> `5907e96` | | | | | | [net.dv8tion:JDA](https://togithub.com/DV8FromTheWorld/JDA) | compile | patch | `5.0.0-beta.23` -> `5.0.0-beta.24` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DV8FromTheWorld/JDA (net.dv8tion:JDA)</summary> ### [`v5.0.0-beta.24`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.0-beta.24): | Bug fixes and entitlement types ### Overview This is a small bugfix release, including some missing features for **premium app entitlements**. ##### Additional Entitlement Features ([#​2667](https://togithub.com/DV8FromTheWorld/JDA/issues/2667)) This release adds support for **test entitlements** and **consumed entitlements**. An entitlement can be *consumed*, marking it as already used. This can be useful for one-time entitlements, which are consumed on use. ```java public boolean hasEntitlement(long skuId, List<Entitlement> entitlements) { return entitlements.stream().anyMatch(e -> e.getSkuIdLong() == skuId && !e.isConsumed()); } ``` ```java public void consumeEntitlement(long skuId, List<Entitlement> entitlements) { entitlements.stream() .filter(e -> e.getSkuIdLong() == skuId && !e.isConsumed()) .findFirst() .ifPresent(entitlement -> entitlement.consume().queue()); } ``` #### New Features - Add `IPostContainerManager#setTopic` by [@​freya022](https://togithub.com/freya022) in [discord-jda/JDA#2666 - Add missing features relating to premium app subscriptions by [@​Tobias123567](https://togithub.com/Tobias123567) in [discord-jda/JDA#2667 #### Changes - Improve logging for gateway connection by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2665 - Add more static analyzer annotations by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2675 - Update SLF4J api and jackson by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2674 #### Bug Fixes - Fix ClassCastException in EntityBuilder#updateMemberCache by [@​Xirado](https://togithub.com/Xirado) in [discord-jda/JDA#2660 - Properly copy poll data in MessageCreateRequest#applyData by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2662 - Make channel access checks consistent by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2679 **Full Changelog**: discord-jda/JDA@v5.0.0-beta.23...v5.0.0-beta.24 ### Installation #### Gradle ```gradle repositories { mavenCentral() } dependencies { implementation("net.dv8tion:JDA:5.0.0-beta.24") } ``` #### Maven ```xml <dependency> <groupId>net.dv8tion</groupId> <artifactId>JDA</artifactId> <version>5.0.0-beta.24</version> </dependency> ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on sunday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/musikbot-client).
BachErik
added a commit
to TwitchTube/DiscordBot
that referenced
this pull request
May 29, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [net.dv8tion:JDA](https://togithub.com/DV8FromTheWorld/JDA) | `5.0.0-beta.23` -> `5.0.0-beta.24` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DV8FromTheWorld/JDA (net.dv8tion:JDA)</summary> ### [`v5.0.0-beta.24`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.0-beta.24): | Bug fixes and entitlement types ### Overview This is a small bugfix release, including some missing features for **premium app entitlements**. ##### Additional Entitlement Features ([#​2667](https://togithub.com/DV8FromTheWorld/JDA/issues/2667)) This release adds support for **test entitlements** and **consumed entitlements**. An entitlement can be *consumed*, marking it as already used. This can be useful for one-time entitlements, which are consumed on use. ```java public boolean hasEntitlement(long skuId, List<Entitlement> entitlements) { return entitlements.stream().anyMatch(e -> e.getSkuIdLong() == skuId && !e.isConsumed()); } ``` ```java public void consumeEntitlement(long skuId, List<Entitlement> entitlements) { entitlements.stream() .filter(e -> e.getSkuIdLong() == skuId && !e.isConsumed()) .findFirst() .ifPresent(entitlement -> entitlement.consume().queue()); } ``` #### New Features - Add `IPostContainerManager#setTopic` by [@​freya022](https://togithub.com/freya022) in [discord-jda/JDA#2666 - Add missing features relating to premium app subscriptions by [@​Tobias123567](https://togithub.com/Tobias123567) in [discord-jda/JDA#2667 #### Changes - Improve logging for gateway connection by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2665 - Add more static analyzer annotations by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2675 - Update SLF4J api and jackson by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2674 #### Bug Fixes - Fix ClassCastException in EntityBuilder#updateMemberCache by [@​Xirado](https://togithub.com/Xirado) in [discord-jda/JDA#2660 - Properly copy poll data in MessageCreateRequest#applyData by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2662 - Make channel access checks consistent by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [discord-jda/JDA#2679 **Full Changelog**: discord-jda/JDA@v5.0.0-beta.23...v5.0.0-beta.24 ### Installation #### Gradle ```gradle repositories { mavenCentral() } dependencies { implementation("net.dv8tion:JDA:5.0.0-beta.24") } ``` #### Maven ```xml <dependency> <groupId>net.dv8tion</groupId> <artifactId>JDA</artifactId> <version>5.0.0-beta.24</version> </dependency> ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/TwitchTube/DiscordBot). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes #2678
Description
Makes checks for channel access consistent.